This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fix deprecate ngtouch #16431
Merged
Fix deprecate ngtouch #16431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-deprecate-ngtouch
branch
from
cd42021 to
d5431e1
Compare
petebacondarwin
approved these changes
Jan 31, 2018
gkalpak
reviewed
Feb 1, 2018
| * the {@link ngTouch.ngSwipeLeft} and {@link ngTouch.ngSwipeRight} directives are | ||
| * deprecated. Instead, stand-alone libraries for touch handling and gesture interaction | ||
| * should be used, for example [HammerJS](https://hammerjs.github.io/) (which is also used by | ||
| * Angular). |
There was a problem hiding this comment.
This might be confusing to people not aware of the AngularJS-vs-Angular distinction.
Maybe add a link to Angular or make it more explicit that you refer to the newer version (or both 😁).
There was a problem hiding this comment.
But the naming change was a pretty big deal so I think it's okay.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: