From 267b217376ed466e9f260ecfdfa15a8227c103ff Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 21 Feb 2014 22:24:27 +0100 Subject: [PATCH] fix($http): send GET requests by default Fixes #5985 Closes #6401 --- src/ng/http.js | 1 + test/ng/httpSpec.js | 14 ++++++++++++++ 2 files changed, 15 insertions(+) diff --git a/src/ng/http.js b/src/ng/http.js index a8b1d9df05f9..defe43dc634f 100644 --- a/src/ng/http.js +++ b/src/ng/http.js @@ -664,6 +664,7 @@ function $HttpProvider() { */ function $http(requestConfig) { var config = { + method: 'get', transformRequest: defaults.transformRequest, transformResponse: defaults.transformResponse }; diff --git a/test/ng/httpSpec.js b/test/ng/httpSpec.js index a0417d9ad99c..d446a80cefda 100644 --- a/test/ng/httpSpec.js +++ b/test/ng/httpSpec.js @@ -405,6 +405,10 @@ describe('$http', function() { $http = $h; }])); + it('should send GET requests if no method specified', inject(function($httpBackend, $http) { + $httpBackend.expect('GET', '/url').respond(''); + $http({url: '/url'}); + })); it('should do basic request', inject(function($httpBackend, $http) { $httpBackend.expect('GET', '/url').respond(''); @@ -1120,6 +1124,16 @@ describe('$http', function() { expect(callback.mostRecentCall.args[0]).toBe('content'); })); + it('should cache request when cache is provided and no method specified', function () { + doFirstCacheRequest(); + + $http({url: '/url', cache: cache}).success(callback); + $rootScope.$digest(); + + expect(callback).toHaveBeenCalledOnce(); + expect(callback.mostRecentCall.args[0]).toBe('content'); + }); + it('should not cache when cache is not provided', function() { doFirstCacheRequest();