Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM audit reports denial of service vulnerability in http-proxy #17738

Closed
trevoreyre opened this issue May 15, 2020 · 3 comments
Closed

NPM audit reports denial of service vulnerability in http-proxy #17738

trevoreyre opened this issue May 15, 2020 · 3 comments

Comments

@trevoreyre
Copy link

🐞 Bug report

Description

npm audit reports a high severity denial of service vulnerability in the http-proxy dependency.

This is in the @angular-devkit/build-angular package. http-proxy is a downstream dependency of webpack-dev-server.

🔬 Minimal Reproduction


npm install --save-dev @angular-devkit/build-angular
npm audit

🔥 Exception or Error


  High            Denial of Service                                             
                                                                                
  Package         http-proxy                                                    
                                                                                
  Patched in      No patch available                                            
                                                                                
  Dependency of   @angular-devkit/build-angular [dev]                           
                                                                                
  Path            @angular-devkit/build-angular > webpack-dev-server >          
                  http-proxy-middleware > http-proxy                            
                                                                                
  More info       https://npmjs.com/advisories/1486                             

🌍 Your Environment

Angular CLI: 9.1.0
Node: 12.14.1
OS: linux x64

Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.901.0
@angular-devkit/build-angular 0.901.0
@angular-devkit/build-ng-packagr 0.901.0
@angular-devkit/build-optimizer 0.901.0
@angular-devkit/build-webpack 0.901.0
@angular-devkit/core 9.1.0
@angular-devkit/schematics 9.1.0
@angular/cdk 9.2.0
@ngtools/webpack 9.1.0
@schematics/angular 9.1.0
@schematics/update 0.901.0
ng-packagr 9.1.0
rxjs 6.5.4
typescript 3.8.3
webpack 4.42.0

Anything else relevant?
This isn't a bug directly in this project, but I'd like to open this issue to track the progress of the vulnerability in dependencies.

npm advisoty: https://npmjs.com/advisories/1486
http-proxy issue: http-party/node-http-proxy#1446
webpack-dev-server issue: webpack/webpack-dev-server#2605

@hardik2801
Copy link

hardik2801 commented May 17, 2020

I' m facing the same issue with Angular CLI: 9.1.6 & Angular: 9.1.7

3 vulnerabilities:

  1. @angular-devkit/build-angular > webpack-dev-server > http-proxy-middleware > http-proxy (severity: High)

  2. karma > http-proxy (severity: High)

  3. @angular-devkit/build-angular > webpack-dev-server > yargs > yargs-parser (severity: Low)

@alan-agius4
Copy link
Collaborator

This should be now solved without the need for us to do anything since this is a transitive dependency.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants