From f5818046a1927ce35f20b92a8454d591326fe394 Mon Sep 17 00:00:00 2001 From: Tuan Pham Date: Tue, 17 Oct 2023 11:39:07 +1100 Subject: [PATCH 1/2] fix: revert build yml file to use secrets to fix the build --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8e8cf2c2..d86277cd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,7 +6,7 @@ on: env: PACT_BROKER_BASE_URL: ${{ secrets.PACT_BROKER_BASE_URL }} - PACT_PROVIDER: ${{ env.PACT_PROVIDER }} + PACT_PROVIDER: ${{ secrets.PACT_PROVIDER }} PACT_BROKER_TOKEN: ${{ secrets.PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP }} REACT_APP_API_BASE_URL: http://localhost:3001 GIT_COMMIT: ${{ github.sha }} From 88d81315f27a625af560239852e184dcaf77b723 Mon Sep 17 00:00:00 2001 From: Tuan Pham Date: Tue, 17 Oct 2023 12:22:49 +1100 Subject: [PATCH 2/2] chore: remove matrix.pact_provider --- .github/workflows/build.yml | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d86277cd..5e6d1332 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,7 +6,7 @@ on: env: PACT_BROKER_BASE_URL: ${{ secrets.PACT_BROKER_BASE_URL }} - PACT_PROVIDER: ${{ secrets.PACT_PROVIDER }} + PACT_PROVIDER: pactflow-example-provider PACT_BROKER_TOKEN: ${{ secrets.PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP }} REACT_APP_API_BASE_URL: http://localhost:3001 GIT_COMMIT: ${{ github.sha }} @@ -15,14 +15,6 @@ env: jobs: test: runs-on: ubuntu-latest - strategy: - matrix: - pact_provider: [ - # "pactflow-example-bi-directional-provider-dredd", - # "pactflow-example-bi-directional-provider-restassured", - # "pactflow-example-bi-directional-provider-postman", - 'pactflow-example-provider' - ] steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 @@ -32,12 +24,12 @@ jobs: run: npm i - name: Test env: - PACT_PROVIDER: ${{ matrix.pact_provider }} + PACT_PROVIDER: ${{ env.PACT_PROVIDER }} run: make test - - name: Publish pacts between pactflow-example-consumer and ${{ matrix.pact_provider }} + - name: Publish pacts between pactflow-example-consumer and ${{ env.PACT_PROVIDER }} run: GIT_BRANCH=${GIT_REF:11} make publish_pacts env: - PACT_PROVIDER: ${{ matrix.pact_provider }} + PACT_PROVIDER: ${{ env.PACT_PROVIDER }} # Runs on branches as well, so we know the status of our PRs can-i-deploy: