Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software development suggestions #135

Open
enahwe opened this issue Dec 6, 2024 · 2 comments
Open

Software development suggestions #135

enahwe opened this issue Dec 6, 2024 · 2 comments

Comments

@enahwe
Copy link

enahwe commented Dec 6, 2024

I think aisuite has a lot of potential. However, I didn't find any logic from an integration and generalization point of view for teams of developers within an IT.

The aisuite code seems to be selfishly centered from a "developer who acts alone in his corner" point of view...

For example, forcing the Python version to at least 3.10 is really a shame because in the real business world there are many Python projects (not too old) that use versions 3.7.x, 3.8.x, 3.9.x and more.
And some of these projects could evolve very quickly by integrating aisuite, but the fact that aisuite requires at least 3.10 does not allow it.

It is also difficult to find a way around the organization of aisuite's system files, it lacks logic. For example, there is no configuration file centralizing the URLs for each provider. If I integrate an Ollama service into my IT, I don't know which configuration file to use to configure the URL of my Ollama!

@chrismstokes-qs
Copy link

You can check the source for each provider in aisuite/provider/<provider_name>_provider.py to see exactly where config parameters are read from. For example, the ollama provider __init__() tells us the ollama URL can be configured through setting the OLLAMA_API_URL environment variable.

"OLLAMA_API_URL", "http://localhost:11434"

@ksolo
Copy link
Collaborator

ksolo commented Dec 6, 2024

@enahwe I can check compatibility to 3.9 but versions below that are EOL and will not be supported (https://devguide.python.org/versions/). If you are using anything older than that I highly recommend you upgrade your versions.

The client can also accept a dict with provider specific configuration if needed. It's outlined in the doc string (https://github.com/andrewyng/aisuite/blob/main/aisuite/client.py#L5-L27). I would agree we can add more documentation on this to highlight it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants