iio: Don't initialize buffer->scan_mask in drivers

commit 9ef1bf3 m2k branch. The scan_mask is managed by the IIO core and should not be directly modified by drivers. Otherwise undefined behaviour might occur. Signed-off-by: Lars-Peter Clausen <[email protected]>
analogdevicesinc · Mar 6, 2018 · a17f06c · a17f06c
1 parent b2c6aaf
commit a17f06c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/drivers/iio/adc/admc_adc.c b/drivers/iio/adc/admc_adc.c
@@ -145,8 +145,6 @@ static int axiadc_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unconfigure_ring;
 
-	*indio_dev->buffer->scan_mask = (1UL << indio_dev->num_channels) - 1;
-
 	dev_info(&pdev->dev, "ADI AIM (0x%X) at 0x%08llX mapped to 0x%p, probed ADC %s as %s\n",
 		 st->pcore_version,
 		 (unsigned long long)mem->start, st->regs, chip_info->name,

diff --git a/drivers/iio/adc/admc_speed.c b/drivers/iio/adc/admc_speed.c
@@ -141,8 +141,6 @@ static int axiadc_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unconfigure_ring;
 
-	*indio_dev->buffer->scan_mask = (1UL << chip_info->num_channels) - 1;
-
 	dev_info(&pdev->dev, "ADI AIM (0x%X) at 0x%08llX mapped to 0x%p, probed ADC %s as %s\n",
 		 st->pcore_version, (unsigned long long)mem->start, st->regs,
 		 chip_info->name, axiadc_read(st, ADI_REG_ID) ? "SLAVE" : "MASTER");

diff --git a/drivers/iio/adc/cf_axi_adc_core.c b/drivers/iio/adc/cf_axi_adc_core.c
@@ -860,10 +860,6 @@ static int axiadc_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unconfigure_ring;
 
-	if (indio_dev->buffer && indio_dev->buffer->scan_mask)
-		*indio_dev->buffer->scan_mask =
-			(1UL << conv->chip_info->num_channels) - 1;
-
 	dev_info(&pdev->dev, "ADI AIM (%d.%.2d.%c) at 0x%08llX mapped to 0x%p,"
 		 " probed ADC %s as %s\n",
 		PCORE_VERSION_MAJOR(st->pcore_version),