Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad performance on large files #52

Open
chmol opened this issue Nov 16, 2021 · 1 comment
Open

Bad performance on large files #52

chmol opened this issue Nov 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@chmol
Copy link

chmol commented Nov 16, 2021

Hi,

My phone is a 8 year old motorola and it takes Ogro ~30 seconds to open a file of 212K around ~ 5000 lines. However opening the same file with Orgzly is instantaneous.

I'm aware I'm on the extreme in this situation and don't expect any resolution but I guess it's worth reporting it.

Thanks,

@amake amake added the enhancement New feature or request label Nov 16, 2021
@amake
Copy link
Owner

amake commented Nov 16, 2021

I do feel your pain. I have a 1.8MB file with 29K lines that takes 30s to parse on my Pixel 2.

A major problem is that Android CPUs are quite weak, especially one from 8 years ago. The same 29K line file takes just 8s to parse on my iPhone XS.

As for the comparison with Orgzly, as far as I know Orgzly is doing much less than Orgro is: Orgro supports basically all org syntax, while Orgzly is probably much more focused and can therefore be faster.

However there is a good chance that my org_parser is not as efficient as it could be. I'd like to improve it but I'm not an expert on PEG parsing and I'm not really sure where to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants