Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for query builder #914

Open
winder opened this issue Mar 7, 2022 · 0 comments
Open

New test for query builder #914

winder opened this issue Mar 7, 2022 · 0 comments
Labels
good first issue Good for newcomers new-bug Bug report that needs triage Team Lamprey

Comments

@winder
Copy link
Contributor

winder commented Mar 7, 2022

Subject of the issue

To compensate for a lack of query performance tests, we can at least test that queries are generated consistently. Especially for specific performance-related items.

In this issue, we should add a test to ensure the root transaction join clause is created correctly. This bit us recently when the small change was lost during a merge conflict.

Acceptance Criteria

A new test is created that generates a transaction search query. Ensure the correct root-intra parameters are used: (t.extra->>'root-intra')::int = root.intra.

@winder winder added new-bug Bug report that needs triage Team Lamprey labels Mar 7, 2022
@chaihoang chaihoang added the good first issue Good for newcomers label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new-bug Bug report that needs triage Team Lamprey
Projects
None yet
Development

No branches or pull requests

2 participants