New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use pysdk's DryRunTransactionResult #3

Closed

Tracked by

tzaffi opened this issue Mar 26, 2022 · 1 comment

Closed

Tracked by

Refactor to use pysdk's DryRunTransactionResult #3

tzaffi opened this issue Mar 26, 2022 · 1 comment

Labels

Contributor

tzaffi commented Mar 26, 2022 •

edited

Loading

PySDK's PR #283 introduces DryRunInspector which is very similar in scope to blackbox.DryRunTransactionResult.

The two classes should be unified.

One possible approach is to rename to a existing class and subclass PySDK's as follows:

class  DryRunInspector(algosdk.DryRunTransactionResult):
    ...

The text was updated successfully, but these errors were encountered:

tzaffi mentioned this issue

Basic Project Setup + Migrating Code from PySDK PR #298 #1

Merged

6 tasks

michaeldiamant added the Team Scytale label

Contributor Author

tzaffi commented Jan 13, 2023

Resolving as the upcoming simulate endpoing will deprecate dry-run in any case so we'll have to refactor everything

tzaffi closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment