You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comment below probably is creating some confusion for some on what deadline AssembleBlock uses thinking it's coming from agreement and dynamic lambda code even though it's from the node code. And deadline is no longer set by agreement in this merge #3165
This comment is on line 811 in TransactionPool code with associated code
// The deadline was generated by the agreement, allocating ProposalAssemblyTime milliseconds for completing proposal
asmStats.TransactionsLoopStartTime = int64(firstTxnGrpTime.Sub(pool.assemblyDeadline.Add(-pool.proposalAssemblyTime)))
AssembleBlock code talks of a deadline also
But I don't see agreement informing the deadline
TxPool's AssembleBlock sets assembly Deadline:
// AssembleBlock assembles a block for a given round, trying not to
// take longer than deadline to finish
Line 939 pool.assemblyDeadline = deadline
Instead node.go file sets the deadline in the below code
deadline := time.Now().Add(node.config.ProposalAssemblyTime)
ub, err := node.transactionPool.AssembleBlock(round, deadline)
Fix if I interpreted correctly,
Remove comments about deadline(AssemblyDeadline) being set by agreement
The text was updated successfully, but these errors were encountered:
pao-beep
changed the title
Comment clarification on TxPool's AssembleBlock function
Clarification on TxPool's AssembleBlock function
Dec 18, 2024
The comment below probably is creating some confusion for some on what deadline AssembleBlock uses thinking it's coming from agreement and dynamic lambda code even though it's from the node code. And deadline is no longer set by agreement in this merge #3165
This comment is on line 811 in TransactionPool code with associated code
AssembleBlock code talks of a deadline also
But I don't see agreement informing the deadline
TxPool's AssembleBlock sets assembly Deadline:
// AssembleBlock assembles a block for a given round, trying not to
// take longer than deadline to finish
Line 939 pool.assemblyDeadline = deadline
Instead node.go file sets the deadline in the below code
deadline := time.Now().Add(node.config.ProposalAssemblyTime)
ub, err := node.transactionPool.AssembleBlock(round, deadline)
Fix if I interpreted correctly,
Remove comments about deadline(AssemblyDeadline) being set by agreement
The text was updated successfully, but these errors were encountered: