From 62ad8ee92b721ec29d3972b06326d4b3ae52c2a1 Mon Sep 17 00:00:00 2001 From: cce <51567+cce@users.noreply.github.com> Date: Wed, 20 Nov 2024 12:04:53 -0500 Subject: [PATCH] switch to "added" instead of "nofilter" for warnings --- .github/workflows/reviewdog.yml | 2 +- .golangci-warnings.yml | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index cbb1bf7147..f967bbd916 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -95,7 +95,7 @@ jobs: -f=golangci-lint \ -name="Lint Warnings" \ -reporter=github-pr-check \ - -filter-mode=nofilter \ + -filter-mode=added \ -fail-on-error=true \ -level=warning - name: Slack Notification diff --git a/.golangci-warnings.yml b/.golangci-warnings.yml index 8ab68f9faf..6faebab656 100644 --- a/.golangci-warnings.yml +++ b/.golangci-warnings.yml @@ -6,23 +6,23 @@ linters: disable-all: true enable: - gosec - - partitiontest +# - partitiontest linters-settings: gosec: # Go 1.22 makes G601 irrelevant - excludes: [G101, G103, G104, G107, G115, G202, G301, G302, G303, G304, G306, G307, G404, G601] - custom: - partitiontest: - path: cmd/partitiontest_linter/plugin.so - description: This custom linter checks files that end in '_test.go', specifically functions that start with 'Test' and have testing argument, for a line 'partitiontest.ParitionTest()' - original-url: github.com/algorand/go-algorand/cmd/partitiontest_linter + excludes: [G101, G103, G104, G107, G202, G301, G302, G303, G304, G306, G307, G404, G601] + # custom: + # partitiontest: + # path: cmd/partitiontest_linter/plugin.so + # description: This custom linter checks files that end in '_test.go', specifically functions that start with 'Test' and have testing argument, for a line 'partitiontest.ParitionTest()' + # original-url: github.com/algorand/go-algorand/cmd/partitiontest_linter severity: default-severity: warning issues: # use these new lint checks on code since #2574 - new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57 +# new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57 # Disable default exclude rules listed in `golangci-lint run --help` (selectively re-enable some below) exclude-use-default: false