Cucumber Tests to validate min-balance field from algod v2/Accounts/{{Account}} response #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tzaffi
reviewed
May 25, 2022
tzaffi
reviewed
May 25, 2022
features/resources/v2algodclient_responsejsons/accountInformationMinBalance.json
Outdated
Show resolved
Hide resolved
tzaffi
suggested changes
May 25, 2022
There was a problem hiding this comment.
Thanks @jds1g14 for submitting this pull request. I think this is very promising.
I am asking for one change: that the test validate the min-balance is parsed correctly, not just that no error results. In doing so, a new step "the parsed Account Information response should have min-balance {min-balance}" is introduced that should parse the min-balance and assert its equality to a quantity provided in the cucumber feature.
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
|
Hey @tzaffi could you re-review when you have a minute, thanks. |
|
We have added min-balance to the indexer API spec and have regenerated the individual SDK specifications where warranted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issue issue 286, the testing sdk has been updated to include a test which validates the min-balance field received from algodv2 accounts call.
The test has been given an unusual tag of @accounts.min-balance so as to avoid the test case running (and failing) as part of any integration/unit test for an SDK in which this change has not been made for.