Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper to the official 1.4 release #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alfert
Copy link
Owner

@alfert alfert commented Mar 16, 2024

No description provided.

@alfert
Copy link
Owner Author

alfert commented Mar 16, 2024

@evnu Any ideas why this fails? It does so also locally on my machine. But I was too long away from Elixir to have a good intuition here.

@evnu
Copy link
Collaborator

evnu commented Mar 16, 2024

@alfert I think I saw that error with proper some time ago. Currently on mobile, but this might give a hint: https://github.com/proper-testing/proper/blob/a5ae5669f01143b0828fc21667d4f5e344aa760b/src/proper_gen.erl#L361 was there a version bump in proper that we need?

@evnu
Copy link
Collaborator

evnu commented Mar 16, 2024

@alfert I thought we fixed the eunit error with this: #224

@evnu
Copy link
Collaborator

evnu commented Mar 16, 2024

@alfert ok, so the current proper release on hex.pm is just too old. That's why we used a git revision.

@alfert
Copy link
Owner Author

alfert commented Mar 16, 2024

This is bad, since we cannot create a proper hex release with dependency on a git hash :-(

@evnu
Copy link
Collaborator

evnu commented Mar 16, 2024

@alfert so time to ask for a PropEr release then I guess 🙈

@evnu
Copy link
Collaborator

evnu commented Jun 13, 2024

Seems that there is no new release coming for PropEr any time soon. :-/

@alfert
Copy link
Owner Author

alfert commented Jun 13, 2024

Yes, feels like Kostis has abandoned PropEr for some time. One way forward could be introducing a fork of PropEr with minor updates (i.e. no new features except for maintenance / upgradability of the Erlang platform). Not sure about it.

@evnu
Copy link
Collaborator

evnu commented Jun 13, 2024

Forking would mean to release PropEr to hex.pm, I think that's probably more work than we want to have for PropCheck :) Can we vendor-in PropEr and have that as part of this source tree?

@alfert
Copy link
Owner Author

alfert commented Jun 13, 2024

As a git submodule?

@evnu
Copy link
Collaborator

evnu commented Jun 13, 2024

If that's possible. This needs to work with mix release as well, I don't know if the Elixir tooling handles vendoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants