Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate icons column in spacemacs #16

Closed
fleimgruber opened this issue Mar 16, 2022 · 9 comments
Closed

Duplicate icons column in spacemacs #16

fleimgruber opened this issue Mar 16, 2022 · 9 comments
Labels
good first issue Good for newcomers

Comments

@fleimgruber
Copy link

fleimgruber commented Mar 16, 2022

Windows 10
Emacs 27.2.50
Spacemacs 011b1454e1dd9bbb1cad425572501ad7506e51bc
dirvish-20220316.720

Steps to reproduce:

  1. M-x dirvish
  2. M-x dirvish-setup-menu
  3. i
  4. i

After step 1:

2022-03-16 12_27_53-Window

After step 3:

2022-03-16 12_29_11-Window_dirvish_icons

After step 4:

2022-03-16 12_30_12-Window_no_dirvish_icons

@fleimgruber
Copy link
Author

For the "neotree" pane to the left the icons are replicated 3 times

image

@alexluigit
Copy link
Owner

alexluigit commented Mar 16, 2022

What is the value of your dirvish-attributes and dirvish--icon-backend?
If you set dirvish-attributes to nil, how does it look like?
And can you test it with emacs -q? Just do

emacs -q -L dirvish -L dirvish/extensions -L all-the-icons.el -l dirvish -l all-the-icons --eval "(progn (setq dirvish-attributes '(all-the-icons)) (dirvish))"

in the packages directory.
It gives me something like this:
2022-03-16_20-30

@fleimgruber
Copy link
Author

dirvish-attributes: nil
dirvish-icon-backend: all-the-icons

emacs -q ... leads to similar results as you showed (i.e. correct behavior).

Any ideas which user config could mess up the display as shown in initial post?

@fleimgruber
Copy link
Author

Another thing that might represent a lead, initially the icons are duplicated twice in the neotree pane:

image

@alexluigit
Copy link
Owner

alexluigit commented Mar 16, 2022

If your dirvish-attributes evals to nil, then these icons are not rendered by dirvish. I don't use spacemacs myself so I'm not sure where these icons came from. Do you have treemacs installed? Maybe it added some hooks in dired-mode-hook and dired-after-readin-hook.

@alexluigit alexluigit changed the title Windows compat: duplicate icons column Duplicate icons column in spacemacs Mar 16, 2022
@fleimgruber
Copy link
Author

Good point, treemacs is installed, but I did not find a way of testing without it yet. Will check back later.

@alexluigit
Copy link
Owner

This should work. But a better solution would be inhibit loading treemacs-icons-dired in the first place.

(remove-hook 'dired-mode-hook 'treemacs-icons-dired-mode)
(remove-hook 'dired-after-readin-hook 'treemacs-icons-dired--display)

@fleimgruber
Copy link
Author

Your workaround works, thanks! Might be good to have a Spacemacs compat section? I could come up with a draft for that.

@alexluigit
Copy link
Owner

Might be good to have a Spacemacs compat section? I could come up with a draft for that.

I agree with the proposal and thanks for your help :)

@alexluigit alexluigit added the good first issue Good for newcomers label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants