Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tv loss deviation from paper #1

Open
JulianKnodt opened this issue Jun 13, 2021 · 2 comments
Open

tv loss deviation from paper #1

JulianKnodt opened this issue Jun 13, 2021 · 2 comments

Comments

@JulianKnodt
Copy link

Hey, this is really cool work on dynamic modeling. I was trying to reproduce the paper and found that I got significantly worse results than your reported values. I was digging through your code because I didn't expect the L2 loss to accurately be able to capture the dynamics, and found tv loss. If I understand correctly, it's an L2 loss between time steps, but evaluated from the same camera position to ensure smoothness. I was wondering if the results in the paper use this loss?

I was also curious what tv stands for, as I'm not super familiar with this.

Thanks!

@JulianKnodt JulianKnodt changed the title tv loss deviation from Paper tv loss deviation from paper Jun 14, 2021
@violetteshev
Copy link

Hi @JulianKnodt, did you manage to reproduce the results? I also got much worse reconstructions.

@JulianKnodt
Copy link
Author

@violetteshev I did not directly reproduce the results, I re-implemented this in my own repo without a coarse/fine approach. Instead, it might be worth to trying to run NR-NeRF on the dataset and see how it performs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants