Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of updating pyo3 methods #21

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

timsaucer
Copy link

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@timsaucer
Copy link
Author

@alamb work in progress, but it shouldn't be too hard to wrap up any remaining issues. I want to test it with datafusion-python before I mark it ready

Copy link
Owner

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timsaucer ❤️

@timsaucer
Copy link
Author

Ok, I pulled in these changes to datafusion-python and see no regression

@timsaucer timsaucer marked this pull request as ready for review December 14, 2024 01:37
@timsaucer
Copy link
Author

@alamb since this targets your fork I can't merge, but I think this is ready for you.

@alamb alamb merged commit 3c5f100 into alamb:alamb/upgrade_to_arrow Dec 14, 2024
25 checks passed
@alamb
Copy link
Owner

alamb commented Dec 14, 2024

Thanks @timsaucer -- I plan to work on the arrow-rs release this weekend too so hopefully we'll be close with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants