Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map and map_with_path_builder of sync version WALs returns a reader backed by unsync::Arena #8

Open
al8n opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@al8n
Copy link
Owner

al8n commented Sep 24, 2024

Suppose a sync version of sync::OrderWal is constructed by map or map_with_path_builder. In that case, there is no reason to use rarena_allocator::sync::Arena as the backend, because map or map_with_path_builder means that the OrderWal cannot be modified anymore so that no data race will happen anymore.

Instance constructed by map or map_with_path_builder is not the same as reader methods of sync::OrderWal. reader let users create a read-only view on an active log, which means the writer can still modify the active log, so a rarena_allocator::sync::Arena is necessary for thread-safe.

@al8n al8n added the enhancement New feature or request label Sep 24, 2024
@al8n al8n self-assigned this Sep 24, 2024
@al8n
Copy link
Owner Author

al8n commented Sep 30, 2024

Blocked by al8n/rarena#14

@al8n al8n added the help wanted Extra attention is needed label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant