Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection #70

Open
amake opened this issue Sep 19, 2023 · 4 comments · May be fixed by #71
Open

Text selection #70

amake opened this issue Sep 19, 2023 · 4 comments · May be fixed by #71

Comments

@amake
Copy link

amake commented Sep 19, 2023

There are some use cases in which it would be desirable to be able to select the text inside HighlightView.

I say some use cases, because there are also times when you don't want it selectable, so I would not advocate for making the text selectable by default.

The modern way of allowing selection is to wrap the desired widget tree in a SelectableRegion (usually via SelectionArea). Ideally users of HighlightView should be able to put a SelectionArea above HighlightView and selection should just work.

@amake amake linked a pull request Sep 19, 2023 that will close this issue
@johnzhu123
Copy link

after I put the HighlightView under a SelectionArea, the text still can't be selected, why?

@amake
Copy link
Author

amake commented Oct 29, 2024

Because #71 needs to be merged before that can work.

@johnzhu123
Copy link

this repo seems have be abandoned, any other package recommend? I just want it can highlight xml and also can copy.

@johnzhu123
Copy link

ok,I found this one worked: https://github.com/1runeberg/code_highlight_view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants