-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bootstrap 4 #30
Comments
Hi coliff, Thank you for your contribution and your suggestion. The Bootswatch Project also supports Bootstrap 4. It is definitely doable. I wonder the advantages over Bootstrap 3. Should I maintain both versions or better switch to Bootstrap 4 for all. If you want to create a PR, I would really appreciate your help. |
Hi @aksakalli - Bootstrap 4 is a big improvement in many ways, it works better across smaller screen sizes due to the extra viewport media query breakpoint. I don't think it's worth maintaining a separate version of the theme for Bootstrap 3. I'm considering using this theme for a project and if I do, I'd like to update it to Bootstrap 4, in which case of course I'll open a PR. Thanks for the work you've done on this theme so far. :-) |
Was this ever accomplished? I'm new to jekyll and trying to use this theme but haven't been able to successfully update it to Bootstrap 4 which I will need for some of the features I want to add to my site. |
It'd be a bit of work, but it'd be great to update this theme to use Bootstrap 4.
The text was updated successfully, but these errors were encountered: