kinesis: use stage materializer with IODispatcher instead of injected EC #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ennru any chance this could be reviewed? |
johanandren
reviewed
Jan 15, 2024
| } | ||
|
|
||
| materializer.system.dispatchers.lookup(dispatcherId) | ||
| } |
There was a problem hiding this comment.
This is identical to what is done for the JMS connector. Sadly we don't have anything more straight forward out of the box.
| schedulerOpt.foreach(scheduler => Future(if (!scheduler.shutdownComplete()) scheduler.shutdown())) | ||
| schedulerOpt.foreach( | ||
| scheduler => Future(if (!scheduler.shutdownComplete()) scheduler.shutdown())(materializer.executionContext) | ||
| ) |
There was a problem hiding this comment.
Contains a lock and possible other blocking stuff, better do it right away inside the stage which is running on the IO dispatcher or make sure this also runs on the ec.
jtjeferreira
commented
Jan 15, 2024
kinesis/src/main/scala/akka/stream/alpakka/kinesis/impl/KinesisSchedulerSourceStage.scala
Outdated
Show resolved
Hide resolved
…sSchedulerSourceStage.scala
jtjeferreira
commented
Jan 17, 2024
kinesis/src/main/scala/akka/stream/alpakka/kinesis/impl/KinesisSchedulerSourceStage.scala
Outdated
Show resolved
Hide resolved
…sSchedulerSourceStage.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KinesisSchedulerSourceStageneeds to run thesoftware.amazon.kinesis.coordinator.Schedulerin a thread. The scheduler runs a loop and usesThread.sleep, which needs careful use because it is a blocking operation.Currently, it uses
Future(scheduler.run()), which will use the implicitExecutionContextfrom the constructor. By default, this EC will be the akka default dispatcher which is not suitable for blocking. Also, note the use ofActorAttributes.IODispatcherininitialAttributeswhich is not having any effect as we are not using the stage materializer.This PR removes the EC from the constructor, and uses the stage logic materializer EC (which will be the IODispatcher) which is aligned with other custom stages in this project.