feat: Jakarta Messaging, #2989 #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted from Alpakka JMS * Jakarta Messaging 3.1 * jakarta.jms package instead of javax.jms
|
It would need to be added in CI |
patriknw
commented
Nov 30, 2023
project/Dependencies.scala
Outdated
| libraryDependencies ++= Seq( | ||
| "jakarta.jms" % "jakarta.jms-api" % "3.1.0", // Eclipse Public License 2.0 + + GPLv2 | ||
| "org.apache.activemq" % "activemq-broker" % "6.0.0" % Test, // ApacheV2 | ||
| "org.apache.activemq" % "activemq-client" % "6.0.0" % Test, // ApacheV2 |
There was a problem hiding this comment.
We have a problem. Jakarta support was added to activemq 6.0.0, but that requires JDK 17. We test and release with 11.
There was a problem hiding this comment.
I guess the answer to this is adding a Docker container for it.
There was a problem hiding this comment.
the client also requires 17, I'll see if there is an easy way to switch to another broker
ennru
reviewed
Nov 30, 2023
project/Dependencies.scala
Outdated
| libraryDependencies ++= Seq( | ||
| "jakarta.jms" % "jakarta.jms-api" % "3.1.0", // Eclipse Public License 2.0 + + GPLv2 | ||
| "org.apache.activemq" % "activemq-broker" % "6.0.0" % Test, // ApacheV2 | ||
| "org.apache.activemq" % "activemq-client" % "6.0.0" % Test, // ApacheV2 |
There was a problem hiding this comment.
I guess the answer to this is adding a Docker container for it.
* because support for Jakarta Messaging was addd in ActiveMQ 6.0, which requires JDK 17 * using Artermis EmbeddedActiveMQ broker
patriknw
commented
Nov 30, 2023
| libraryDependencies ++= Seq( | ||
| "jakarta.jms" % "jakarta.jms-api" % "3.1.0", // Eclipse Public License 2.0 + + GPLv2 | ||
| "org.apache.activemq" % "artemis-jakarta-server" % "2.31.2" % Test, // ApacheV2 | ||
| "org.apache.activemq" % "artemis-jakarta-client" % "2.31.2" % Test, // ApacheV2 |
There was a problem hiding this comment.
Had to rewrite the tests to use Artemis instead. Was not trivial, but working now. 139f1f2
|
unrelated fail in other modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes fix to close sessions on connection loss from #3041
Refs #2989