Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Shopify: new stream Gift Card #26557

Closed
igrankova opened this issue May 25, 2023 · 4 comments
Closed

Source Shopify: new stream Gift Card #26557

igrankova opened this issue May 25, 2023 · 4 comments

Comments

@igrankova
Copy link
Contributor

What area the feature impact?

Connectors

Revelant Information

Tell us about the problem you're trying to solve

Gift Card
A gift card is an alternative payment method. Each gift card has a unique code that is entered during checkout. Its balance can be redeemed over multiple checkouts. Optionally, a gift card can assigned to a specific customer. Gift card codes cannot be retrieved after they're created—only the last four characters can be retrieved.
Shopify Plus

The Gift Card resource is available for private apps installed on Shopify Plus stores. As of API version 2021-04, the Gift Card resource is also available for custom apps installed on Shopify Plus stores.

Your app must request the write_gift_cards and read_gift_cards access scopes. Merchants that want to sell or issue gift cards also need to activate the gift card feature in the Shopify admin.

Describe the solution you’d like

Research pros and cons for implementing this stream

@igrankova
Copy link
Contributor Author

See more information about Blocked status in Source Shopify: upgrade sandbox account to Shopify Plus subscription airbytehq/airbyte-internal-issues#1831

@bazarnov bazarnov self-assigned this Aug 17, 2023
@bazarnov
Copy link
Collaborator

It was decided to proceed with certification without this stream being implemented. Closing this for now.
cc @bmcgilli @oustynova @lazebnyi @sherifnada

@nickjoanis
Copy link

nickjoanis commented Feb 20, 2024

I came across this issue while searching for any open discussions on implementing the stream. I have developed a working example for the gift card stream in my fork, with straightforward modifications based on the existing ShopifyIncrementalStream class.

Should there be any interest in revisiting and reopening this issue, I am prepared to contribute my implementation as my first official contribution to the project. I would appreciate your feedback on whether you see value in this addition. Thank you

@bazarnov
Copy link
Collaborator

@nickjoanis Hello and thank you for your interest in enhancing the Source Shopify. This stream is quite useful to have. We are interested in your contribution for sure. We now working on delivering the BULK Api version of the connector, as of here: #32345, all the improvements for this source are frozen until it's merged.

Feel free to make the PR and put me to the reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants