You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the *Worker interfaces to resemble the interfaces in #2130.
The inputs to a worker should be everything that is necessary to run a job. Right now some of the main inputs (like images) are nested within helper classes like IntegrationLauncher which are not easily to enforce as JSON serializable. They also contain things like process builder factories, which are really options at the worker runner level more than the worker itself.
If the images are top-level arguments for workers this becomes much easier, but requires some refactoring where they are called.
To put it another way: make WorkerRun be the level of worker abstraction, not Worker
The text was updated successfully, but these errors were encountered:
Change the
*Worker
interfaces to resemble the interfaces in #2130.The inputs to a worker should be everything that is necessary to run a job. Right now some of the main inputs (like images) are nested within helper classes like
IntegrationLauncher
which are not easily to enforce as JSON serializable. They also contain things like process builder factories, which are really options at the worker runner level more than the worker itself.If the images are top-level arguments for workers this becomes much easier, but requires some refactoring where they are called.
To put it another way: make
WorkerRun
be the level of worker abstraction, notWorker
The text was updated successfully, but these errors were encountered: