Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve worker construction interface #2177

Closed
jrhizor opened this issue Feb 23, 2021 · 1 comment · Fixed by #2232
Closed

improve worker construction interface #2177

jrhizor opened this issue Feb 23, 2021 · 1 comment · Fixed by #2232
Assignees
Labels
temporal type/enhancement New feature or request

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Feb 23, 2021

Change the *Worker interfaces to resemble the interfaces in #2130.

The inputs to a worker should be everything that is necessary to run a job. Right now some of the main inputs (like images) are nested within helper classes like IntegrationLauncher which are not easily to enforce as JSON serializable. They also contain things like process builder factories, which are really options at the worker runner level more than the worker itself.

If the images are top-level arguments for workers this becomes much easier, but requires some refactoring where they are called.

To put it another way: make WorkerRun be the level of worker abstraction, not Worker

@cgardens
Copy link
Contributor

PR up. I think we are aligned on the approach. Need to fix all the tests tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
temporal type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants