From b2fd84a0dc47df46e1d83a5e8026a820f9834e35 Mon Sep 17 00:00:00 2001 From: Anatolii Yatsuk Date: Fri, 12 Jul 2024 17:45:46 +0300 Subject: [PATCH] Fix description --- .../sources/declarative/declarative_component_schema.yaml | 4 ++-- .../declarative/models/declarative_component_schema.py | 4 +++- .../connectors/source-jira/source_jira/manifest.yaml | 5 ++--- .../connectors/source-jira/source_jira/streams.py | 4 ++-- .../connectors/source-slack/source_slack/manifest.yaml | 1 - 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yaml b/airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yaml index 8a72bbae543a..23e9749ae426 100644 --- a/airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yaml +++ b/airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yaml @@ -813,8 +813,8 @@ definitions: type: boolean default: False global_parent_cursor: - title: Global Parent Cursor - description: Indicates whether the parent stream state as one cursor instead of partitions. + title: Whether to store cursor as one value instead of per partition + description: If parent stream have thousands of partitions, it can be more efficient to store cursor as one value instead of per partition. Lookback window should be used to avoid missing records that where added during the sync type: boolean default: false lookback_window: diff --git a/airbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.py b/airbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.py index 022f5cea0f81..45e8df5b329e 100644 --- a/airbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.py +++ b/airbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.py @@ -1081,7 +1081,9 @@ class DatetimeBasedCursor(BaseModel): title='Whether to skip requests if the start time equals the end time', ) global_parent_cursor: Optional[bool] = Field( - False, description='Indicates whether the parent stream state as one cursor instead of partitions.', title='Global Parent Cursor' + False, + description='If parent stream have thousands of partitions, it can be more efficient to store cursor as one value instead of per partition. Lookback window should be used to avoid missing records that where added during the sync', + title='Whether to store cursor as one value instead of per partition', ) lookback_window: Optional[str] = Field( None, diff --git a/airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml b/airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml index 6b434ba4d035..5b7b97e24116 100644 --- a/airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml +++ b/airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml @@ -1249,7 +1249,7 @@ definitions: transformations: - type: AddFields fields: - - path: [ "issueId" ] + - path: ["issueId"] value_type: string value: "{{ stream_slice.issue_id }}" state_migrations: @@ -1277,7 +1277,7 @@ definitions: transformations: - type: AddFields fields: - - path: [ "issueId" ] + - path: ["issueId"] value_type: string value: "{{ stream_slice.issue_id }}" state_migrations: @@ -1287,7 +1287,6 @@ definitions: path: "issue/{{ stream_slice.issue_id }}/worklog" extract_field: "worklogs" - streams: # Full refresh streams diff --git a/airbyte-integrations/connectors/source-jira/source_jira/streams.py b/airbyte-integrations/connectors/source-jira/source_jira/streams.py index 1aee8a3fb170..189a44129292 100644 --- a/airbyte-integrations/connectors/source-jira/source_jira/streams.py +++ b/airbyte-integrations/connectors/source-jira/source_jira/streams.py @@ -214,8 +214,8 @@ class Issues(IncrementalJiraStream): def __init__(self, **kwargs): super().__init__(**kwargs) self._project_ids = [] - self.issue_fields_stream = IssueFields(authenticator=self._session.auth, domain=self._domain, projects=self._projects) - self.projects_stream = Projects(authenticator=self._session.auth, domain=self._domain, projects=self._projects) + self.issue_fields_stream = IssueFields(authenticator=self._http_client._session.auth, domain=self._domain, projects=self._projects) + self.projects_stream = Projects(authenticator=self._http_client._session.auth, domain=self._domain, projects=self._projects) def path(self, **kwargs) -> str: return "search" diff --git a/airbyte-integrations/connectors/source-slack/source_slack/manifest.yaml b/airbyte-integrations/connectors/source-slack/source_slack/manifest.yaml index 02782bddea2a..3a0ebfcdf1fb 100644 --- a/airbyte-integrations/connectors/source-slack/source_slack/manifest.yaml +++ b/airbyte-integrations/connectors/source-slack/source_slack/manifest.yaml @@ -251,7 +251,6 @@ definitions: datetime: "{{ now_utc().strftime('%Y-%m-%dT%H:%M:%SZ') }}" datetime_format: "%Y-%m-%dT%H:%M:%SZ" - threads_stream: $ref: "#/definitions/stream_base" $parameters: