Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker watcher: Port is required? #88

Open
niko opened this issue Aug 22, 2014 · 1 comment
Open

Docker watcher: Port is required? #88

niko opened this issue Aug 22, 2014 · 1 comment

Comments

@niko
Copy link

niko commented Aug 22, 2014

Sorry for this being rather a question than an issue… the Docker watcher requires a port for each service if I understand the code right. Wouldn't it make sense to have the watcher just look for an image-tag combination and figure out the port (or ports if there are several) by itself? That way one could spin up a new deploy with a "staging" tag, test drive it, then add a "production" tag and take down the old deploy. Or am I missing something?

@bcicen
Copy link

bcicen commented Oct 17, 2014

Presumably so if you have a single container with multiple open ports(say, an http server and some type of monitoring daemon) you can discover them both and apply different backend settings in haproxy. Hence, service discovery rather than container discovery.

Concerning the image-tag combination -- I do currently deploy this way and have #96 open for the feature. This also provides the benefit of preventing conflicting image versions of an application from being used as valid backends if your orchestration tool or sysadmin doesn't always clean up after itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants