force overwrite metadata in table properties #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyu-hou
changed the title
cristianfr
reviewed
Nov 9, 2023
| tableUtils: TableUtils, | ||
| forceOverwriteMetadata: Boolean = false): collection.Seq[String] = { | ||
| if (forceOverwriteMetadata) { | ||
| return collection.Seq.empty |
There was a problem hiding this comment.
This makes sure it won't recompute, but will the next run recompute?
I think when we save we store the table properties so it should probably work? Else may be take the opportunity to set the table properties here (hence overwriting the metadata as the flag implies)
There was a problem hiding this comment.
good point. This will only overwrite the metadata when we do a new run
There was a problem hiding this comment.
Addressed comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new flag to overwrite metadata if needed to avoid dropping previously computed intermediate tables
Why / Goal
This PR can avoid dropping the previously computed intermediate tables if the version update is negligible
Test Plan
Checklist
Reviewers
@airbnb/zipline-maintainers