Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support data sync #494

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feat: Support data sync #494

wants to merge 10 commits into from
+129 −52

Conversation

qcgm1978
Copy link
Contributor

@qcgm1978 qcgm1978 commented Aug 9, 2023

  • including online sync using MongoDB Atlas and local file sync
截屏2023-08-09 18 50 08

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 6:22am

sunner
sunner requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@sunner sunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution.

IMO, the MongoDB introduces complication. A downloadable JSON file is enough for syncing because they can use OneDrive, iCloud and etc.

src/background.js Outdated Show resolved Hide resolved
src/store/index.js Outdated Show resolved Hide resolved
src/utils/storage.js Outdated Show resolved Hide resolved
@qcgm1978 qcgm1978 requested a review from sunner August 13, 2023 07:56
@qcgm1978 qcgm1978 marked this pull request as draft August 13, 2023 07:57
@qcgm1978 qcgm1978 marked this pull request as ready for review August 13, 2023 08:04
qcgm1978
qcgm1978 commented Aug 13, 2023
View reviewed changes
Copy link
Contributor Author

@qcgm1978 qcgm1978 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done.

sunner
sunner requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@sunner sunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢。主要两个问题：

  1. 这个设置，是否放到 general 里更好？
  2. utils 没有删除

src/background.js Outdated Show resolved Hide resolved
src/components/ChatSetting.vue Outdated Show resolved Hide resolved
src/i18n/locales/en.json Outdated Show resolved Hide resolved
src/i18n/locales/zh.json Outdated Show resolved Hide resolved
src/i18n/locales/zh.json Show resolved Hide resolved
@qcgm1978
Copy link
Contributor Author

多谢。主要两个问题：

  1. 这个设置，是否放到 general 里更好？
  2. utils 没有删除

移动到了general面板里，utils里面放了download_by_link方法，需要在SettingsModal.vue 和 ChatSetting.vue 里面调用

@qcgm1978 qcgm1978 requested a review from sunner August 13, 2023 16:37
sunner
sunner reviewed Aug 14, 2023
View reviewed changes
src/components/ChatSetting.vue Show resolved Hide resolved
src/utils/setting.js Outdated Show resolved Hide resolved
@qcgm1978 qcgm1978 requested a review from sunner August 14, 2023 06:22
@sunner
Copy link
Member

sunner commented Aug 16, 2023

@qcgm1978 Since #487 merged, something changed. I need some time to resolve the conflicts, especially reconsider the Chat tab. Sorry for the inconvenience and give me some time please.

@qcgm1978
Copy link
Contributor Author

@qcgm1978 Since #487 merged, something changed. I need some time to resolve the conflicts, especially reconsider the Chat tab. Sorry for the inconvenience and give me some time please.

Please feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunner sunner Awaiting requested review from sunner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qcgm1978 @sunner