BREAKING_CHANGE: dissallow using a dependency with different scopes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 97.28% 97.33% +0.05%
==========================================
Files 46 46
Lines 2023 2028 +5
Branches 344 344
==========================================
+ Hits 1968 1974 +6
Misses 41 41
+ Partials 14 13 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58.
This change explicitly prohibits using the same dependency with multiple scopes within a given DAG, thus resolving #58.
It is important to note the within a given DAG part: you can still use the same dependency in two completely separate DAGs with different scopes. In this case, caching between them will work: if the dependency is cached in an outer scope, the cached value will be used, but if it is cached in an inner scope, it will be ignored (this behavior is here)