-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[quick view] Some gradients not yet supported #3458
Comments
Reviewed. Leaving open in sprint 24 to disable hover preview for these gradients. Later on, when we get a CEF that supports them, we should turn this back on. So, once #3482 is merged, let's remove the sprint milestone but leave it open. |
These gradients are now disabled, so removing sprint 24 milestone. |
@redmunds The w3 style gradients are still not showing up with CEF3.1453.1255 which is using Chromium version 27.0.1453.73. The Regex isn't capturing the w3 gradient syntax (linear-gradient, repeating-linear-gradient, radial-gradient, repeating-radial-gradient)... Was there code in a branch somewhere that just needs to be tested? The unit tests for w3 gradients are in master but commented out so it isn't clear where I should be looking. |
@JeffryBooher The regex has definitely not been updated for the "repeating" formats. I'm not sure if regex needs to be updated for the other new w3 formats. Note the existing code adds a Someone added some of the (commented out) units test just because they were easy to add. |
I tested the 'to' and I think most or all of them are fixed with CEF3.1453.1255; however, code changes need to be made to the QuickView extension to make them work. |
Taking this one as @redmunds is going on sabbatical soon. |
Confirmed. Closing. |
http://dev.w3.org/csswg/css-images-3/
This applies to both linear-gradient() and radial-gradient() types. There are also new repeating-linear-gradient() and repeating-radial-gradient() types. These formats are supported in the latest Chrome (26), but the version of CEF Brackets is using has Chrome 25.
The text was updated successfully, but these errors were encountered: