HTML attributes code hinting filter #2263
Conversation
|
|
||
| if (unfiltered.length) { | ||
| if (filtered.length) { |
There was a problem hiding this comment.
Switching to filtered is ok for your if block, but it's not ok for other if blocks. Make sure you also adjust others.
|
Ooops... thanks! I don't know how did I miss that... Fixed, double-checked and changes pushed ;) |
ghost
assigned
| it("should not find attributes before the tag is opened", function () { | ||
| var pos = {"ch": 0, "line": 0}; | ||
| setContentAndUpdatePos(pos, | ||
| ['<html>', '<body>', '<div class="clearfix">'], |
There was a problem hiding this comment.
Our coding guideline is to use double quotes for all strings and the one nested inside then can use a single quote. So can you switch to double-quotes in all your test cases?
There was a problem hiding this comment.
Sure, no problem, will fix that.
I actually copy/pasted from one of the tests above and all the existing ones have the quotes inverted. Do you want me to change those as a bonus, or should we let them be for now?
There was a problem hiding this comment.
Yes, please do change them if you don't mind.
|
@RaymondLim All the quotes have been updated (hopefully) and the I've modified and fixed the test. |
|
Looks good, merging now |
HTML attributes code hinting filter
This pull requests should cover some of this story about filtering code hints https://trello.com/card/code-hinting-filter/4f90a6d98f77505d7940ce88/592, in particular, filtering HTML attributes already used inside a tag.
It adds a new
getTagAttributesmethod insideHTMLUtilsthat compiles a list of all used attributes inside a tag. This list is then used insideAttrHintsto exclude the already used attributes from the complete list.