This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Color Editor CSS cleanups #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pickers, they are always set via JS in the constructor
ghost
assigned 
| this.$buttonList = this.$element.find("ul.button-bar"); | ||
| this.$rgbaButton = this.$element.find(".rgba"); | ||
| this.$hexButton = this.$element.find(".hex"); | ||
| this.$hslButton = this.$element.find(".hsla"); | ||
| this.$currentColor = this.$element.find(".current_color"); | ||
| this.$currentColor = this.$element.find(".current-color"); | ||
| this.$lastColor = this.$element.find(".last_color"); |
There was a problem hiding this comment.
You need to change this to .last-color. Actually, this has also been renamed to original_color.
|
Nice work! You did exactly what @peterflynn said in #2216. I only found one instance that you missed in converting We're closing down for Sprint 17 and your pull request just missed our pencil-downs yesterday. Also, you may need to redo part of your work with the latest code as @peterflynn had a major clean up in ColorEditor.js. |
Conflicts: src/extensions/default/InlineColorEditor/ColorEditor.js src/extensions/default/InlineColorEditor/ColorEditorTemplate.html src/extensions/default/InlineColorEditor/css/main.css
|
Great! ready to merge but we have to wait until sprint 17 close. |
|
Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2216.