Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites from shortened URLs missing some valid paths #1215

Open
HitmanInWis opened this issue Aug 19, 2024 · 1 comment
Open

Rewrites from shortened URLs missing some valid paths #1215

HitmanInWis opened this issue Aug 19, 2024 · 1 comment

Comments

@HitmanInWis
Copy link

HitmanInWis commented Aug 19, 2024

The archetype includes rewrites from shortened URLs to full URLs in https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/dispatcher.ams/src/conf.d/rewrites/__appId___rewrite.rules

RewriteCond %{REQUEST_URI} !^/apps
RewriteCond %{REQUEST_URI} !^/bin
RewriteCond %{REQUEST_URI} !^/content
RewriteCond %{REQUEST_URI} !^/etc
RewriteCond %{REQUEST_URI} !^/home
RewriteCond %{REQUEST_URI} !^/libs
RewriteCond %{REQUEST_URI} !^/saml_login
RewriteCond %{REQUEST_URI} !^/system
RewriteCond %{REQUEST_URI} !^/tmp
RewriteCond %{REQUEST_URI} !^/var
RewriteCond %{REQUEST_URI} (.html|.jpe?g|.png|.svg)$
RewriteRule ^/(.*)$ /content/${CONTENT_FOLDER_NAME}/$1 [PT,L]

Given these paths are all checked w/o a trailing / the following paths will not be rewritten to their full paths:

  • /contents/abc.html
  • /systems/abc.html
    etc...

I believe all of these paths, with the exception of maybe /saml_login should be updated with a trailing /

@HitmanInWis
Copy link
Author

slight addendum - would need to leave /etc as-is or if changing to /etc/ then also add /etc.clientlibs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant