Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update assessment article properties in sample course (fix #3626 #3627) #3628

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix: Update assessment article properties in sample course (fix #3626 #3627) #3628

merged 1 commit into from
Dec 9, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #3626 #3627

Update

  • Sets _assessment._attempts to the default value of -1 instead of an invalid string value
  • Sets _trickle._onChildren to true to match the behavior when the value is not explicitly set

@swashbuck swashbuck self-assigned this Dec 3, 2024
kirsty-hames
kirsty-hames approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 8c9981c into master Dec 9, 2024
2 checks passed
@oliverfoster oliverfoster deleted the issue/3626 branch December 9, 2024 10:19
@oliverfoster oliverfoster changed the title Update: Update assessment article properties in sample course (fix #3626 #3627) Fix: Update assessment article properties in sample course (fix #3626 #3627) Dec 9, 2024
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@semantic-release-bot
Chore(release): 5.41.13 [skip ci]
3cc774b 
## [5.41.13](v5.41.12...v5.41.13) (2024-12-09)

### Fix

* Update assessment properties in sample course (#3628) ([8c9981c](8c9981c)), closes [#3628](#3628)
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 5.41.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample course: Assessment _attempts value is not valid
4 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool