Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Support for node v23.0.0 (fixes #3618) #3619

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix: Support for node v23.0.0 (fixes #3618) #3619

merged 1 commit into from
Oct 23, 2024

Conversation

oliverfoster
Copy link
Member

fixes #3618

Fix

@oliverfoster oliverfoster self-assigned this Oct 21, 2024
joe-replin
joe-replin approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@joe-replin joe-replin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to compile again with Node v23. Thank you so much.

joe-allen-89
joe-allen-89 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 4bd264f into master Oct 23, 2024
2 checks passed
@oliverfoster oliverfoster deleted the issue/3618 branch October 23, 2024 08:53
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
@semantic-release-bot
Chore(release): 5.41.10 [skip ci]
519fd69 
## [5.41.10](v5.41.9...v5.41.10) (2024-10-23)

### Fix

* Support for node v23.0.0 (fixes #3618) (#3619) ([4bd264f](4bd264f)), closes [#3618](#3618) [#3619](#3619)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.41.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-replin joe-replin joe-replin approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug high priority released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node v23.0.0 compilation issues
4 participants
@oliverfoster @joe-replin @cahirodoherty-learningpool @joe-allen-89