Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting port with leading invalid characters #229

Closed
anonrig opened this issue Feb 22, 2023 · 1 comment · Fixed by #230
Closed

Setting port with leading invalid characters #229

anonrig opened this issue Feb 22, 2023 · 1 comment · Fixed by #230

Comments

@anonrig
Copy link
Member

anonrig commented Feb 22, 2023

The latest changes makes these tests fail, because this isn't included in the WPT JSON tests.

  "url-setters-stripping.any.js": {
    "fail": {
      "unexpected": [
        "Setting port with leading U+0009 (https:)",
        "Setting port with leading U+000A (https:)",
        "Setting port with leading U+000D (https:)",
        "Setting port with leading U+0009 (wpt++:)",
        "Setting port with leading U+000A (wpt++:)",
        "Setting port with leading U+000D (wpt++:)"
      ]
    }
  }
@anonrig
Copy link
Member Author

anonrig commented Feb 22, 2023 •
edited
Loading

Prevents Node.js to update to the latest Ada version: nodejs/node#46772

@anonrig anonrig mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check and eliminate non ascii on port setter ada-url/ada
1 participant
@anonrig