Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kaggle system call #2892

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Improve kaggle system call #2892

merged 2 commits into from
Jul 3, 2024

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Use subprocess.Popen instead of os.system

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
deeplake/auto/unstructured/kaggle.py 33.33% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nvoxland-al nvoxland-al merged commit a6bfc93 into main Jul 3, 2024
9 of 10 checks passed
@nvoxland-al nvoxland-al deleted the kaggle_update branch July 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khustup2 khustup2 khustup2 approved these changes

@activesoull activesoull activesoull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvoxland-al @activesoull @khustup2 @nvoxland