Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python shutting down error message #1509

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix python shutting down error message #1509

merged 1 commit into from
Feb 22, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1509 (669d974) into main (06b0f5f) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   92.19%   92.23%   +0.03%     
==========================================
  Files         185      185              
  Lines       16236    16239       +3     
==========================================
+ Hits        14969    14978       +9     
+ Misses       1267     1261       -6     
Flag Coverage Δ
unittests 92.23% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/dataset.py 92.98% <50.00%> (-0.25%) ⬇️
hub/api/dataset.py 90.15% <0.00%> (+0.75%) ⬆️
hub/core/lock.py 88.65% <0.00%> (+4.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b0f5f...669d974. Read the comment docs.

@farizrahman4u farizrahman4u merged commit a997d62 into main Feb 22, 2022
@farizrahman4u farizrahman4u deleted the fr_ds_del_fix branch February 22, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants