Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1604] hub.read() from remote URLs #1480

Merged
merged 19 commits into from
Feb 14, 2022
Merged

[AL-1604] hub.read() from remote URLs #1480

merged 19 commits into from
Feb 14, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@davidbuniat
Copy link
Member

should have reused our storage abstraction as seen in the other PR

@farizrahman4u farizrahman4u marked this pull request as draft February 7, 2022 17:23
@farizrahman4u farizrahman4u marked this pull request as ready for review February 9, 2022 15:21
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1480 (7dbcd08) into main (d34ca60) will increase coverage by 0.49%.
The diff coverage is 96.09%.

❗ Current head 7dbcd08 differs from pull request most recent head 27767f6. Consider uploading reports for the commit 27767f6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1480      +/-   ##
==========================================
+ Coverage   91.14%   91.64%   +0.49%     
==========================================
  Files         185      185              
  Lines       15282    15577     +295     
==========================================
+ Hits        13929    14275     +346     
+ Misses       1353     1302      -51     
Flag Coverage Δ
unittests 91.64% <96.09%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/sample.py 88.93% <92.06%> (+1.13%) ⬆️
hub/api/read.py 100.00% <100.00%> (ø)
hub/api/tests/test_api.py 100.00% <100.00%> (+2.22%) ⬆️
hub/core/storage/gcs.py 73.68% <100.00%> (+0.63%) ⬆️
hub/core/storage/s3.py 64.78% <100.00%> (+2.56%) ⬆️
hub/util/path.py 93.75% <100.00%> (+3.27%) ⬆️
hub/core/lock.py 85.12% <0.00%> (-4.23%) ⬇️
hub/core/compute/provider.py 94.44% <0.00%> (-2.62%) ⬇️
hub/core/query/autocomplete.py 79.54% <0.00%> (-1.71%) ⬇️
hub/core/meta/encode/chunk_id.py 95.93% <0.00%> (-0.82%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18cf7d4...27767f6. Read the comment docs.

try:
from hub.core.storage.gcs import GCSProvider
except ImportError:
GCProvider = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo

Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo, rest looks good to me

@farizrahman4u farizrahman4u merged commit bf3eb46 into main Feb 14, 2022
@farizrahman4u farizrahman4u deleted the fr_remote_read branch February 14, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants