-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1604] hub.read() from remote URLs #1480
Conversation
should have reused our storage abstraction as seen in the other PR |
…into fr_remote_read
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 91.14% 91.64% +0.49%
==========================================
Files 185 185
Lines 15282 15577 +295
==========================================
+ Hits 13929 14275 +346
+ Misses 1353 1302 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hub/core/sample.py
Outdated
try: | ||
from hub.core.storage.gcs import GCSProvider | ||
except ImportError: | ||
GCProvider = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo, rest looks good to me
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges