Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #1169 #1452

Merged
merged 8 commits into from
Feb 3, 2022
Merged

fixes issue #1169 #1452

merged 8 commits into from
Feb 3, 2022

Conversation

gaurav879
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Added 3 chances for the user to login using CLI

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2022

CLA assistant check
All committers have signed the CLA.

@davidbuniat
Copy link
Member

Thanks @gaurav879 for the contribution! and I agree that 3x authentication would be a better UX. Just curious what motivated you the problem?

@gaurav879
Copy link
Contributor Author

@davidbuniat, you're welcome. I'm new to open source, and I'm working on some good first issues and familiarising myself with the codebase. The above problem was simpler, and I felt confident in my ability to address it. I intend to work on and contribute to more issues in the future.

hub/cli/auth.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gaurav879! Everything looks good, I've left a couple of small comments and I can approve once those are addressed. Looking forward to seeing more contributions from you 🚀

@tatevikh tatevikh requested a review from FayazRahman January 24, 2022 16:51
@gaurav879
Copy link
Contributor Author

Hey, @AbhinavTuli I have made the requested changes. Sorry for the delay from my side.

hub/cli/auth.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor change would be to switch from print to click.echo for consistency.

@tatevikh tatevikh merged commit 250fbae into activeloopai:main Feb 3, 2022
@mikayelh
Copy link
Collaborator

mikayelh commented Feb 5, 2022

Yay, @gaurav879! Thanks for contributing. Hit us up in community slack for some swag. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants