-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issue #1169 #1452
fixes issue #1169 #1452
Conversation
Thanks @gaurav879 for the contribution! and I agree that 3x authentication would be a better UX. Just curious what motivated you the problem? |
@davidbuniat, you're welcome. I'm new to open source, and I'm working on some good first issues and familiarising myself with the codebase. The above problem was simpler, and I felt confident in my ability to address it. I intend to work on and contribute to more issues in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gaurav879! Everything looks good, I've left a couple of small comments and I can approve once those are addressed. Looking forward to seeing more contributions from you 🚀
Hey, @AbhinavTuli I have made the requested changes. Sorry for the delay from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor change would be to switch from print to click.echo for consistency.
Yay, @gaurav879! Thanks for contributing. Hit us up in community slack for some swag. :) |
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
Added 3 chances for the user to login using CLI