Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing in query for blocks #1448

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Fix indexing in query for blocks #1448

merged 1 commit into from
Jan 22, 2022

Conversation

aliubimov
Copy link
Contributor

No description provided.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Jan 20, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1448 (8cf0fd5) into main (c1130de) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   92.10%   92.14%   +0.03%     
==========================================
  Files         178      178              
  Lines       14325    14327       +2     
==========================================
+ Hits        13194    13201       +7     
+ Misses       1131     1126       -5     
Flag Coverage Δ
unittests 92.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/query/query.py 85.81% <100.00%> (+0.19%) ⬆️
hub/core/lock.py 85.24% <0.00%> (+1.63%) ⬆️
hub/core/storage/s3.py 73.59% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1130de...8cf0fd5. Read the comment docs.

@tatevikh tatevikh requested a review from FayazRahman January 21, 2022 16:23
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for the case that this fixes?

@tatevikh tatevikh merged commit a590eb2 into activeloopai:main Jan 22, 2022
@aliubimov aliubimov deleted the hotfix/query branch January 24, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants