Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RCE in video decompression #1425

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Fix RCE in video decompression #1425

merged 1 commit into from
Dec 30, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #1425 (0c4a33e) into main (b90fa83) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1425      +/-   ##
==========================================
- Coverage   92.31%   91.81%   -0.51%     
==========================================
  Files         175      175              
  Lines       14134    13937     -197     
==========================================
- Hits        13048    12796     -252     
- Misses       1086     1141      +55     
Flag Coverage Δ
unittests 91.81% <100.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/compression.py 86.98% <100.00%> (-2.22%) ⬇️
hub/api/tests/test_api_with_compression.py 89.85% <0.00%> (-10.15%) ⬇️
hub/core/tests/test_compression.py 94.39% <0.00%> (-5.61%) ⬇️
hub/tests/path_fixtures.py 90.17% <0.00%> (-3.41%) ⬇️
hub/core/fast_forwarding.py 66.66% <0.00%> (-2.30%) ⬇️
hub/api/tests/test_api.py 97.74% <0.00%> (-2.26%) ⬇️
hub/core/meta/tensor_meta.py 84.75% <0.00%> (-1.92%) ⬇️
hub/core/chunk/sample_compressed_chunk.py 98.18% <0.00%> (-1.82%) ⬇️
hub/core/storage/s3.py 71.91% <0.00%> (-1.69%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90fa83...0c4a33e. Read the comment docs.

@farizrahman4u farizrahman4u merged commit c5771d2 into main Dec 30, 2021
@farizrahman4u farizrahman4u deleted the fr_fix_rce_video branch December 30, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants