Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1443] Tiling + Slicing + Updating #1374

Merged
merged 48 commits into from
Dec 20, 2021
Merged

[AL-1443] Tiling + Slicing + Updating #1374

merged 48 commits into from
Dec 20, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

https://activeloop.atlassian.net/browse/AL-1443
Lazy download of tiled sample slices + updating

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2021

CLA assistant check
All committers have signed the CLA.

@farizrahman4u farizrahman4u mentioned this pull request Dec 5, 2021
7 tasks
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1374 (38c2207) into main (f6b62ca) will increase coverage by 0.60%.
The diff coverage is 98.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   92.40%   93.01%   +0.60%     
==========================================
  Files         175      174       -1     
  Lines       13043    13369     +326     
==========================================
+ Hits        12053    12435     +382     
+ Misses        990      934      -56     
Flag Coverage Δ
unittests 93.01% <98.75%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/meta/encode/base_encoder.py 98.34% <ø> (+0.01%) ⬆️
hub/core/tiling/deserialize.py 93.65% <92.68%> (-2.78%) ⬇️
hub/core/chunk_engine.py 97.96% <99.27%> (+0.44%) ⬆️
hub/api/tests/test_api.py 100.00% <100.00%> (+2.54%) ⬆️
hub/api/tests/test_api_tiling.py 100.00% <100.00%> (ø)
hub/core/chunk/base_chunk.py 98.12% <100.00%> (+0.11%) ⬆️
hub/core/chunk/chunk_compressed_chunk.py 98.78% <100.00%> (+0.03%) ⬆️
hub/core/chunk/sample_compressed_chunk.py 100.00% <100.00%> (+1.81%) ⬆️
hub/core/chunk/uncompressed_chunk.py 100.00% <100.00%> (ø)
hub/core/dataset/dataset.py 94.11% <100.00%> (+0.07%) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b62ca...38c2207. Read the comment docs.

@tatevikh tatevikh requested a review from AbhinavTuli December 9, 2021 23:51
@aliubimov aliubimov self-requested a review December 13, 2021 16:51
@aliubimov
Copy link
Contributor

Please also add missing coverage

samples.append(sample)
last_shape = shape
return format_read_samples(samples, index, aslist)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we using this function anymore?

Copy link
Contributor Author

@farizrahman4u farizrahman4u Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function cannot handle the indexing logic for tiled samples, as the whole sample might not be available. Behavior stays same for non-tile samples, the logic is moved to numpy().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants