Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1574] Fast chunk compression #1366

Merged
merged 29 commits into from
Dec 16, 2021
Merged

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Dec 1, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Speed up chunk compression by predicting length of compressed bytes using an adaptive compression ratio.
https://activeloop.atlassian.net/browse/AL-1574

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1366 (3f9abcb) into main (9aa892e) will increase coverage by 0.03%.
The diff coverage is 97.58%.

❗ Current head 3f9abcb differs from pull request most recent head 831b7a4. Consider uploading reports for the commit 831b7a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   92.23%   92.27%   +0.03%     
==========================================
  Files         174      174              
  Lines       12706    12758      +52     
==========================================
+ Hits        11720    11772      +52     
  Misses        986      986              
Flag Coverage Δ
unittests 92.27% <97.58%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/chunk/chunk_compressed_chunk.py 98.15% <96.80%> (+0.50%) ⬆️
hub/api/tests/test_api_tiling.py 100.00% <100.00%> (ø)
hub/core/chunk/base_chunk.py 98.02% <100.00%> (+0.08%) ⬆️
hub/core/chunk/sample_compressed_chunk.py 98.18% <100.00%> (+0.06%) ⬆️
hub/core/chunk/test_chunk_compressed.py 98.95% <100.00%> (+0.05%) ⬆️
hub/core/compression.py 87.33% <100.00%> (+0.04%) ⬆️
hub/core/meta/encode/base_encoder.py 98.32% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa892e...831b7a4. Read the comment docs.

@farizrahman4u farizrahman4u changed the title Fast chunk compression [AL-1574] Fast chunk compression Dec 1, 2021
@tatevikh tatevikh requested a review from aliubimov December 9, 2021 17:09
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes + codecov

Copy link
Contributor

@aliubimov aliubimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix coverage

@farizrahman4u farizrahman4u merged commit 1096ebf into main Dec 16, 2021
@farizrahman4u farizrahman4u deleted the fr_fast_chunk_compression branch December 16, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants