Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default dataset setting from public to private #1317

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

istranic
Copy link
Contributor

@istranic istranic commented Nov 1, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1317 (74733b6) into main (d588ed1) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   91.22%   91.33%   +0.11%     
==========================================
  Files         142      142              
  Lines        9936     9938       +2     
==========================================
+ Hits         9064     9077      +13     
+ Misses        872      861      -11     
Impacted Files Coverage Δ
hub/api/dataset.py 95.23% <ø> (ø)
hub/core/dataset/dataset.py 92.97% <ø> (ø)
hub/api/tests/test_dataset.py 100.00% <100.00%> (ø)
hub/core/dataset/hub_cloud_dataset.py 87.75% <0.00%> (+6.12%) ⬆️
hub/core/lock.py 91.11% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d588ed1...74733b6. Read the comment docs.

@tatevikh tatevikh merged commit 2db4ba9 into main Nov 2, 2021
@tatevikh tatevikh deleted the fix/public-private branch November 2, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants