Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cloud dataset bugs #1294

Merged
merged 9 commits into from
Oct 27, 2021
Merged

Fix/cloud dataset bugs #1294

merged 9 commits into from
Oct 27, 2021

Conversation

verbose-void
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

fixes the

sample = ds[0]

bug when ds is a hub cloud dataset

also fixes the "cannot overwrite dataset" bug, again for hub cloud datasets.

added mnist test

hub/core/dataset/__init__.py Outdated Show resolved Hide resolved
@verbose-void verbose-void marked this pull request as draft October 26, 2021 12:46
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1294 (1e4a604) into main (c1f908e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   91.27%   91.32%   +0.04%     
==========================================
  Files         141      142       +1     
  Lines        9862     9871       +9     
==========================================
+ Hits         9002     9015      +13     
+ Misses        860      856       -4     
Impacted Files Coverage Δ
hub/api/dataset.py 95.23% <100.00%> (ø)
hub/api/tests/test_hosted_datasets.py 100.00% <100.00%> (ø)
hub/core/dataset/__init__.py 86.66% <100.00%> (ø)
hub/core/dataset/dataset.py 92.97% <100.00%> (+0.05%) ⬆️
hub/core/dataset/hub_cloud_dataset.py 81.63% <100.00%> (ø)
hub/cli/list_datasets.py 81.81% <0.00%> (-18.19%) ⬇️
hub/client/utils.py 67.21% <0.00%> (-14.76%) ⬇️
hub/util/exceptions.py 80.57% <0.00%> (-0.36%) ⬇️
hub/core/meta/tensor_meta.py 88.96% <0.00%> (+0.68%) ⬆️
hub/util/storage.py 96.49% <0.00%> (+3.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f908e...1e4a604. Read the comment docs.

@verbose-void verbose-void marked this pull request as ready for review October 27, 2021 11:53
@verbose-void verbose-void merged commit b191cd1 into main Oct 27, 2021
@verbose-void verbose-void deleted the fix/cloud-dataset-bugs branch October 27, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants