-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cloud dataset bugs #1294
Merged
Merged
Fix/cloud dataset bugs #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diveafall
suggested changes
Oct 26, 2021
farizrahman4u
approved these changes
Oct 26, 2021
Diveafall
approved these changes
Oct 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
+ Coverage 91.27% 91.32% +0.04%
==========================================
Files 141 142 +1
Lines 9862 9871 +9
==========================================
+ Hits 9002 9015 +13
+ Misses 860 856 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
fixes the
bug when ds is a hub cloud dataset
also fixes the "cannot overwrite dataset" bug, again for hub cloud datasets.
added mnist test