Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaked semaphore issue on mac #1291

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fix leaked semaphore issue on mac #1291

merged 2 commits into from
Nov 10, 2021

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1291 (1586733) into main (9aa6a19) will decrease coverage by 0.08%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   90.90%   90.81%   -0.09%     
==========================================
  Files         146      146              
  Lines       10474    10478       +4     
==========================================
- Hits         9521     9516       -5     
- Misses        953      962       +9     
Flag Coverage Δ
unittests 90.81% <75.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/__init__.py 96.96% <75.00%> (-3.04%) ⬇️
hub/core/lock.py 82.22% <0.00%> (-8.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa6a19...1586733. Read the comment docs.

@aliubimov
Copy link
Contributor

Please, rebase on top of feature/refactor-pytorch

@aliubimov aliubimov force-pushed the feature/refactor-pytorch branch from 47a23f3 to c1e1e19 Compare November 3, 2021 00:30
@AbhinavTuli AbhinavTuli changed the base branch from feature/refactor-pytorch to main November 9, 2021 12:18
@farizrahman4u farizrahman4u merged commit e34c532 into main Nov 10, 2021
@farizrahman4u farizrahman4u deleted the fix/mac_pt_refactor branch November 10, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants