Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better retries for s3 #1283

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Better retries for s3 #1283

merged 4 commits into from
Oct 26, 2021

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1283 (8ad086b) into main (e2ad2b0) will decrease coverage by 0.05%.
The diff coverage is 35.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   91.72%   91.66%   -0.06%     
==========================================
  Files         138      138              
  Lines        9578     9587       +9     
==========================================
+ Hits         8785     8788       +3     
- Misses        793      799       +6     
Impacted Files Coverage Δ
hub/core/storage/s3.py 71.91% <22.58%> (+0.23%) ⬆️
hub/__init__.py 100.00% <100.00%> (ø)
hub/api/dataset.py 96.03% <100.00%> (+0.07%) ⬆️
hub/integrations/pytorch/pytorch_old.py 85.39% <0.00%> (-5.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ad2b0...8ad086b. Read the comment docs.

@@ -54,10 +55,13 @@
"ingest_kaggle",
"compressions",
"htypes",
"config",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verbose-void verbose-void merged commit 60aac4a into main Oct 26, 2021
@verbose-void verbose-void deleted the better_s3_retry branch October 26, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants