Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1629] Optional dependencies + refac #1277

Merged
merged 32 commits into from
Feb 8, 2022
Merged

[AL-1629] Optional dependencies + refac #1277

merged 32 commits into from
Feb 8, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1277 (cfa5765) into main (efc8b0b) will decrease coverage by 0.08%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
- Coverage   91.54%   91.45%   -0.09%     
==========================================
  Files         179      179              
  Lines       14812    14837      +25     
==========================================
+ Hits        13559    13569      +10     
- Misses       1253     1268      +15     
Flag Coverage Δ
unittests 91.45% <58.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
hub/core/compression.py 78.28% <56.25%> (-0.69%) ⬇️
hub/core/storage/gcs.py 73.05% <80.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc8b0b...cfa5765. Read the comment docs.

@farizrahman4u farizrahman4u marked this pull request as ready for review October 25, 2021 07:56
@tatevikh tatevikh requested a review from FayazRahman February 3, 2022 15:48
@AbhinavTuli AbhinavTuli changed the title Optional dependencies + refac [AL-1629] Optional dependencies + refac Feb 3, 2022
@farizrahman4u
Copy link
Contributor Author

LGTM, fix lint.

@AbhinavTuli AbhinavTuli merged commit faeef59 into main Feb 8, 2022
@AbhinavTuli AbhinavTuli deleted the fr_dep branch February 8, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants