Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions #1241

Merged
merged 41 commits into from
Nov 1, 2021
Merged

Add GitHub actions #1241

merged 41 commits into from
Nov 1, 2021

Conversation

araratpoghosyan
Copy link
Contributor

@araratpoghosyan araratpoghosyan commented Oct 7, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

This PR brings GitHub actions support in Hub repository. All the checks (including complex) tests were taken from appropriate CircleCI workflow.

Note

Since GitHub actions workers (including paid ones) have only 2 CPU cores, the worker number was reduced from 4 to 2.

Kaggle tests were disabled by removing --kaggle flag from tests.

After merge

After the PR is merged, the build must be included in settings area as a required step for PR checks

@araratpoghosyan araratpoghosyan marked this pull request as ready for review October 7, 2021 16:35
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1241 (2084cd2) into main (2402279) will decrease coverage by 0.49%.
The diff coverage is 88.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   91.83%   91.34%   -0.50%     
==========================================
  Files         136      142       +6     
  Lines        9056     9926     +870     
==========================================
+ Hits         8317     9067     +750     
- Misses        739      859     +120     
Impacted Files Coverage Δ
hub/core/lock.py 91.11% <ø> (+6.66%) ⬆️
hub/htype.py 100.00% <ø> (ø)
hub/core/storage/s3.py 71.91% <46.15%> (-15.97%) ⬇️
hub/core/storage/tests/test_storage_provider.py 83.92% <57.14%> (-16.08%) ⬇️
hub/core/sample.py 86.61% <80.00%> (+0.44%) ⬆️
hub/core/dataset/hub_cloud_dataset.py 81.63% <81.63%> (ø)
hub/core/ipc.py 83.00% <83.00%> (ø)
hub/util/json.py 83.78% <83.78%> (ø)
hub/core/chunk_engine.py 88.02% <85.71%> (-0.54%) ⬇️
hub/integrations/pytorch/pytorch.py 92.85% <85.71%> (+2.61%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2402279...2084cd2. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! circleci kinda sucks

@gautamkrishnar gautamkrishnar force-pushed the feature/github-actions-build branch from 9969bf0 to 459eabe Compare October 29, 2021 17:05
@farizrahman4u farizrahman4u merged commit d588ed1 into main Nov 1, 2021
@farizrahman4u farizrahman4u deleted the feature/github-actions-build branch November 1, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants