Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Action Pack 8.0 #942

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Test against Action Pack 8.0 #942

merged 1 commit into from
Nov 9, 2024

Conversation

tagliala
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (4a6410e) to head (b9dd56e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          14       14           
  Lines         557      557           
=======================================
  Hits          551      551           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala force-pushed the chore/test-against-ap-80 branch 3 times, most recently from 67bb55d to f03d2a9 Compare October 23, 2024 12:55
@tagliala tagliala force-pushed the chore/test-against-ap-80 branch from f03d2a9 to 4c5dbe0 Compare November 8, 2024 08:21
@tagliala tagliala marked this pull request as ready for review November 8, 2024 08:24
@tagliala tagliala requested a review from javierjulio November 8, 2024 08:25
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same review comments submitted on your Arbre PR apply here. Thank you.

@tagliala tagliala force-pushed the chore/test-against-ap-80 branch from 4c5dbe0 to b9dd56e Compare November 9, 2024 07:10
@tagliala
Copy link
Contributor Author

tagliala commented Nov 9, 2024

Done, same consideration about Rails 6.1 (will do that in a new PR with a different branch and a change to gemspec)

@tagliala tagliala requested a review from javierjulio November 9, 2024 07:17
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 204708c into master Nov 9, 2024
23 checks passed
@tagliala tagliala deleted the chore/test-against-ap-80 branch November 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants